Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[dart-jaguar] Fixes error accessing default converters #3361

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

josh-burton
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes an issue introduced in: #3245

this.converters was causing errors as the default converters are declared outside of the API client.

CC: @wing328

`this.converters` was causing errors as the default converters are declared outside of the API client.
@wing328
Copy link
Member

wing328 commented Jul 18, 2019

cc @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)

Copy link
Contributor

@jaumard jaumard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :) I miss that one ^^
Thanks !

@wing328 wing328 merged commit 1aa8a2b into OpenAPITools:master Jul 18, 2019
@wing328 wing328 added this to the 4.1.0 milestone Jul 18, 2019
@wing328
Copy link
Member

wing328 commented Aug 10, 2019

@athornz thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants