-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Run Qt5 client sample test #3415
Conversation
e698e65
to
036430f
Compare
Unfortunately, since I upgrade the qt5 client petstore example to openapi 3.0 spec, the test fails to compile: https://travis-ci.org/OpenAPITools/openapi-generator/builds/562992191#L5084 Should we revert #3400 ? |
Yes, Lets revert #3400 . I did not have a chance to compile it, and assumed it was done. |
Done here: #3458 |
036430f
to
ec7b5c1
Compare
CircleCI job failed: do I need to install Qt for CircleCI too? It doesn't seems that the issue is related. |
I restarted the CI job and it passed. |
Another option is to use drone.io that we just setup over the weekend: https://github.com/OpenAPITools/openapi-generator/blob/master/CI/.drone.yml If there's a docker image with those dependencies installed, we can set it up very easily with drone.io. |
@wing328 |
No more feedback/question from me. The change looks good 👍 |
* master: (122 commits) Fix #3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...
We start seeing the following intermittent build errors in the master branch:
Please take a look when you've time. We will restart the job for the time being. |
This might be due to memory leak fixed here: #3661 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
I just added Qt5 PetStore sample test. I'm not sure Qt5 is installed on the CI so I'll fix it if not.
@ravinikam @stkrwork @etherealjoy