Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[OCaml] various enhancements #3483

Merged
merged 6 commits into from
Jul 29, 2019
Merged

[OCaml] various enhancements #3483

merged 6 commits into from
Jul 29, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • rename generator from ocaml-client to ocaml (similar conventions for other languages)
  • code format
  • add auto-generated README
  • add window batch script
  • remove debugOperations from shell script

We'll setup CI later to ensure the auto-generated OCaml client compiles without issues.

cc @cgensoul

@wing328 wing328 merged commit 6e31765 into master Jul 29, 2019
@wing328 wing328 deleted the ocaml-enhance branch July 29, 2019 02:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant