Fix invalid spring properties prefix

[MelleD]

fixes #3381

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master . Default: master.
• @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)
  --

Description of the PR

Fix invalid spring properties prefix

[macjohnny]

LGTM

[macjohnny]

please fix these lines, too:

openapi-generator/modules/openapi-generator/src/main/resources/JavaSpring/libraries/spring-cloud/clientConfiguration.mustache

Lines 27 to 31 in 7a16b03

	{{=<% %>=}}@Value("${<%title%>.security.<%name%>.username:}")<%={{ }}=%>
	private String {{{name}}}Username;
	{{=<% %>=}}@Value("${<%title%>.security.<%name%>.password:}")<%={{ }}=%>
	private String {{{name}}}Password;

openapi-generator/modules/openapi-generator/src/main/resources/JavaSpring/libraries/spring-cloud/clientConfiguration.mustache

Lines 41 to 42 in 7a16b03

	{{=<% %>=}}@Value("${<%title%>.security.<%name%>.key:}")<%={{ }}=%>
	private String {{{name}}}Key;

[MelleD]

@macjohnny Will this work?

 {{=<% %>=}}@Value("${{{#lambda.lowercase}}<%title%>{{/lambda.lowercase}}.security.<%name%>.username:}")<%={{ }}=%>
  private String {{{name}}}Username;

[macjohnny]

Will this work?

I guess it wont, because the {{=<% %>=}} indicates erb style tags, see http://mustache.github.io/mustache.5.html

maybe this should be converted to normal mustache tags, and escape the { and }

[MelleD]

Ok got it. Yes it would be better to escape the {, but there is no default way to escape braces.

It think a variable is a good solution:

 public char openbrace= `{`;
 public char closebrace= `{`;

Then i could use:

@Value("${{openBrace}}{#lambda.lowercase}}{{{title}}}{{/lambda.lowercase}}.security.{{{name}}}.username:{{closebrace}}")

Do you have a proposal,where i should add the openbrace variable?

[macjohnny]

how about

 @Value("${{=<% %>=}}{<%={{ }}=%>{{#lambda.lowercase}}{{{title}}}{{/lambda.lowercase}}.security.{{name}}.key:{{=<% %>=}}}<%={{ }}=%>")
 private String {{{name}}}Key; 

[MelleD]

This will work, but is not really readable.
That's why I like the workaround with the variable. It's readable and easy to understand.

[macjohnny]

ok, a variable is a good solution. you can add it e.g. here
https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java#L115

[macjohnny]

LGTM

[wing328]

@sirwayne thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553