Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[aspnetcore] Add max/min length attributes for models #3588

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

yilinjuang
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Generate max min length attribute for models. Fix missing closing bracket.

@wing328
@jimschubert

@yilinjuang yilinjuang changed the title Add max/min length attributes for models [aspnetcore] Add max/min length attributes for models Aug 8, 2019
@wing328
Copy link
Member

wing328 commented Aug 11, 2019

cc @A-Joshi

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 123efc5 into OpenAPITools:master Aug 13, 2019
@yilinjuang yilinjuang deleted the fix-length branch August 13, 2019 04:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants