[maven] Support user overrides for serverVariables (carryover from #3363) #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
4 tasks
jimschubert
changed the title
Adds server variables option to the maven plugin. The way our CI works, the maven plugin's snapshot dependency can cause issues with samples verify task (appears that master may publish while a PR build is verifying). It looks like we've always done maven lugin work after core feature work - probably as a workaround to the SNAPSHOT resolution issue.
jimschubert
force-pushed
the
server-variable-substitution-mvn
branch
from
b3fe411 to
840989f
Compare
|
Looks like the issue I was having was the property name not matching the configuration element name. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
This should be merged after #3363, and after the core feature is published as a snapshot. There's an issue with consuming core changes in the maven plugin within the same build during a SNAPSHOT build, likely due to how we do the samples verification using a different profile from the original/cached build.