Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[aspnetcore] Fix nullable enum and duplicate model #3622

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

yilinjuang
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Generate enum as nullable only if isNullable is true. Remove generation of sub-enum in class if enum is model which is already generated in another file.

@wing328
@jimschubert

@auto-labeler
Copy link

auto-labeler bot commented Aug 12, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 4.1.1 milestone Aug 13, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit f5327b6 into OpenAPITools:master Aug 13, 2019
@yilinjuang yilinjuang deleted the fix-enum branch August 14, 2019 06:22
@wing328
Copy link
Member

wing328 commented Aug 26, 2019

@frankyjuang thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

@edag94
Copy link

edag94 commented Aug 26, 2019

Thanks for this PR! Will be closing the issue I raised and link it to this

@wing328
Copy link
Member

wing328 commented Sep 21, 2019

@frankyjuang when you've time next week, please kindly PM me via Slack

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants