Use javax.annotation.processing.Generated for Java 11 native client

[bbdouglas]

Before Java 9, the Generated annotation was part of JEE and in the
javax.annotation package. Starting with Java 9, it is now part
of the standard SDK, under the new javax.annotation.processing
package.

This change creates a custom Generated annotation template for the
native clientlib, since it is guaranteed to be run in Java 11+.

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Adds a new custom generatedAnnotation.mustache template for the native HttpClient library with the correct Generated package name for Java 9+.

Fixes #3636

[bbdouglas]

CC @cbornet @jeff9finger @karismann @Zomzog Java technical committee

@macjohnny as reviewer of #3434 that introduced this new generator.

This is meant to address bug #3636

[jeff9finger]

LGTM

[macjohnny]

@bbdouglas where/how is this file included/referenced?

[jmini]

@macjohnny:

This is with usage of {{>generatedAnnotation}} in the templates.

---

But you are right, when this construct is used, inside Java/pojo.mustache:

openapi-generator/modules/openapi-generator/src/main/resources/Java/pojo.mustache

Line 5 in 94d4e0c

{{>generatedAnnotation}}{{#discriminator}}{{>typeInfoAnnotation}}{{/discriminator}}{{>xmlAnnotation}}

Then I think that Java/generatedAnnotation.mustache is used and not Java/libraries/native/generatedAnnotation.mustache even if you are generating the native client.

So I guess this PR does not really work.

[bbdouglas]

@macjohnny @jmini As you rightly pointed out, this is referenced in pojo.mustache. I do believe that this PR is working, as I have tested it locally. Unfortunately, the checked-in samples have the timestamp omitted, so it can't be checked there.

I remember looking this up before, and there is a hierarchy of file locations that are searched when looking for a mustache file. First it tries the library directory, and if it doesn't exist there, it backs off to the general Java directory. That's how I can have my own custom pom.mustache file, for example. I can't remember where I saw the code that does the mustache file locating, though, so let me see if I can find it.

[jmini]

I can't remember where I saw the code that does the mustache file locating, though, so let me see if I can find it.

The place I know is:

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/AbstractGenerator.java

Line 153 in 2d7785a

public String getFullTemplateFile(CodegenConfig config, String templateFile) {

But I thought this is not used when a template calls an other template.

[wing328]

@bbdouglas thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

[evanlott]

Does this issue still exist? I have tried plugin versions 4.2.2 and 4.1.3 and keep getting javax.annotation.Generated in my gen'd server stubs. Was the solution not carried over to versions beyond 4.1.1 or something? Perhaps I'm not using the solution correctly, like maybe missing a config option?

Edit: I see now that I just need to specify the hideGenerationTimestamp=true in my configOptions. Disregard my comment :)

[dmitry-weirdo]

Still not clear how to use it.

When I add

                            <configOptions>
                                <hideGenerationTimestamp>true</hideGenerationTimestamp>
                            </configOptions>

, no @Generated annotation is generated at all.

Can you please explain how to set up the custom annotation? AFAIU, I have to somehow override generatedAnnotation.mustache within the generator that I am using (namely jaxrs-jersey).