Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Go]URLEncode path parameters #3643

Merged
merged 3 commits into from
Aug 16, 2019
Merged

[Go]URLEncode path parameters #3643

merged 3 commits into from
Aug 16, 2019

Conversation

kraney
Copy link
Contributor

@kraney kraney commented Aug 14, 2019

Proposed fix for #3591

Simply wraps usage of path parameters with a call to url.QueryEscape().

@wing328
Copy link
Member

wing328 commented Aug 15, 2019

Thanks for the fix. Please update the sample by running

"./bin/go-petstore.sh"
"./bin/go-petstore-withxml.sh"

so that the CI can verify the change.

@wing328
Copy link
Member

wing328 commented Aug 16, 2019

cc Go Technical Committee: @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

@wing328 wing328 added this to the 4.1.1 milestone Aug 16, 2019
wing328
wing328 approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit b83fe0c into OpenAPITools:master Aug 16, 2019
@semtexzv
Copy link
Contributor

Is there any work done to support array parameters ? Current implementation just wraps them in [] and outputs a string.

@bendrucker bendrucker mentioned this pull request Jun 11, 2020
Merged
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
Client: Go Issue: Bug
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kraney @wing328 @semtexzv