-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[java][client][resteasy][jersey2][google-api-client][okhttp-json] several fixes to make sent requests more accurate #3703
[java][client][resteasy][jersey2][google-api-client][okhttp-json] several fixes to make sent requests more accurate #3703
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
I found one issue with Jersey2 and sending a
I think the 2 solutions mentioned on StackOverflow might be interesting:
Any opinion (can be solved in a follow-up PR) |
WIP: For the jersey2 client, for Line 691 in 4575b30
Instead when body is null |
ceffe3f
to
346c04a
Compare
…"null" as text when no request-body is set
…ethod-Override" Fixes OpenAPITools#3720
346c04a
to
2b53faa
Compare
2b53faa
to
2bb9395
Compare
The jersey2 part seems to be fine, it manages to solve #3719 I don't really have too many experience with the rest of the libraries, so it's hard for me to comment them, but 👍 from me on the jersey2 part and the general aim of this PR. |
…ject-for-empty-request-body
Approved by @kevinoid in #3276 (comment) Discussed with @wing328 on Slack. |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
Fixes #3276
Fixes #3719
Fixes #3720