Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Various minor improvements to the Nim client generator #3883

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 13, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • mark as "beta"
  • reformat the code
  • add copyright header

cc @hokamoto

@wing328 wing328 added this to the 4.1.3 milestone Sep 13, 2019
@wing328 wing328 merged commit 95c4a05 into master Sep 13, 2019
@wing328 wing328 deleted the nim_improve branch September 13, 2019 08:48
@wing328 wing328 changed the title Various minor improvements to the nim client generator Various minor improvements to the Nim client generator Sep 13, 2019
jimschubert added a commit that referenced this pull request Sep 13, 2019
* master: (22 commits)
  various minor improvements to nim generator (#3883)
  Add Nim client code generator (#3879)
  updated google-api-client version from 1.23.0 to 1.30.2.  Bugfix #3625 (#3882)
  typescript-fetch: fix missing comma in multiple imports (#3881)
  [scala][client] add Scala code generation test (#3859)
  typescript-node: Use HttpError class when rejecting promises (#3876)
  update stable release
  update doc, samples (#3875)
  BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
  fix version in readme
  Prepare v4.1.2 release (#3873)
  Rename gRPC generator to "protobuf-schema" (#3864)
  typescript-axios: Fix baseoptions (#3866)
  Fix/r/serialization fix and minor 3xx resp fix (#3817)
  [typescript-angular] allow empty string basePath (#3489)
  typescript-inversify: improve check for required parameters, support multiple media types (#3849)
  [C++][Pistache] Add missing setter for arrays (#3837)
  Adds Http Info To Dart Api (#3851)
  [Java][okhttp-gson] fix failure to deserialize floats (#3846)
  maven-plugin-plugin 3.6.0 (#3854)
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant