[typescript][node]: Add accept header if produces is not empty

[ghost]

Uses the correct Accept media types as specified in the OpenApi
specifications.

relates to #3944

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
  @akehir @macjohnny

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[macjohnny]

why only the first one?

[macjohnny]

please run the bin/typescript-node-petstore-all.sh script only, not the openapi3 version

[macjohnny]

thanks for the PR

[ghost]

Thanks for the review! Somehow managed to copied the {{#-first}} bit from the lua code, the only generator who seems to do it differently... I updated the pull request and the samples look much better now.

[macjohnny]

LGTM

[macjohnny]

the tests seem to fail, can you have a look at https://travis-ci.org/OpenAPITools/openapi-generator/builds/591210342?utm_source=github_status&utm_medium=notification ?

[ghost]

After running the client.ts through a debugger I found out that getPetById specifies to produce 'application/xml' and 'application/json'. When accepting both (in that order), the endpoint returns xml. That fails to deserialize...

What to you reckon? Never include 'application/xml'? If 'application/json' is present, don't include anything else?

And how should that logic be implemented? There is no if in mustache, so how to modify the produces field?

[macjohnny]

thanks for the analysis, good to know.
see e.g.

openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/builds/default/api/pet.service.ts

Lines 89 to 106 in c8ac41c

	// to determine the Accept header
	const httpHeaderAccepts: string[] = [
	];
	const httpHeaderAcceptSelected: string | undefined = this.configuration.selectHeaderAccept(httpHeaderAccepts);
	if (httpHeaderAcceptSelected !== undefined) {
	headers = headers.set('Accept', httpHeaderAcceptSelected);
	}
	// to determine the Content-Type header
	const consumes: string[] = [
	'application/json',
	'application/xml'
	];
	const httpContentTypeSelected: string | undefined = this.configuration.selectHeaderContentType(consumes);
	if (httpContentTypeSelected !== undefined) {
	headers = headers.set('Content-Type', httpContentTypeSelected);
	}

openapi-generator/modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache

Lines 250 to 264 in c8ac41c

	// to determine the Accept header
	const httpHeaderAccepts: string[] = [
	{{#produces}}
	'{{{mediaType}}}'{{#hasMore}},{{/hasMore}}
	{{/produces}}
	];
	const httpHeaderAcceptSelected: string | undefined = this.configuration.selectHeaderAccept(httpHeaderAccepts);
	if (httpHeaderAcceptSelected !== undefined) {
	{{^useHttpClient}}
	headers.set('Accept', httpHeaderAcceptSelected);
	{{/useHttpClient}}
	{{#useHttpClient}}
	headers = headers.set('Accept', httpHeaderAcceptSelected);
	{{/useHttpClient}}
	}

[ghost]

Ok good idea, would you be happy with this solution:

{{#hasProduces}}
        const produces = [{{#produces}}'{{{mediaType}}}'{{#hasMore}}, {{/hasMore}}{{/produces}}];
        // give precedence to 'application/json'
        if (produces.indexOf('application/json') >= 0) {
            localVarHeaderParams.Accept = 'application/json';
        } else {
            localVarHeaderParams.Accept = produces.join(',');
        }
{{/hasProduces}}

[macjohnny]

LGTM