Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Import time when properties are slices of time.Time #3973

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Sep 27, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax @bvwells @grokify @kemokemo @bkabrda

Description of the PR

Fixes #3972 by adding import time when a model has a property of type "array of time.Time". Tested against the input in #3972 description.

Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch!

@wing328 wing328 merged commit af9eb8d into OpenAPITools:master Oct 1, 2019
@wing328 wing328 added this to the 4.1.3 milestone Oct 1, 2019
Jesse0Michael pushed a commit to Jesse0Michael/openapi-generator that referenced this pull request Oct 3, 2019
@wing328
Copy link
Member

wing328 commented Oct 4, 2019

@masci thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

@masci masci mentioned this pull request Oct 15, 2019
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing import of 'time' package when model contains array of dates
3 participants