Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[kotlin] parcelize is now stable #4003

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Sep 30, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

According to the last checkbox I think I should tag you, sorry if I'm wrong...
@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04)

This PR fixes #4002 because Parcelize is stable since Kotlin 1.3.41.

@auto-labeler
Copy link

auto-labeler bot commented Sep 30, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 4.1.3 milestone Oct 1, 2019
@wing328
Copy link
Member

wing328 commented Oct 1, 2019

@4brunu thanks for the PR, which looks reasonable to me.

The CI failure is not related to this PR.

@wing328 wing328 merged commit 775d96c into OpenAPITools:master Oct 1, 2019
Jesse0Michael pushed a commit to Jesse0Michael/openapi-generator that referenced this pull request Oct 3, 2019
@4brunu 4brunu deleted the feature/parcelize-stable branch October 4, 2019 11:55
@wing328
Copy link
Member

wing328 commented Oct 4, 2019

@4brunu thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [Kotlin] Parcelize is now stable
2 participants