Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Swift4] update swift4 samples with swiftlint, update test scripts #4009

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 1, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • update swift4 samples with swiftlint
  • update test scripts

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03)

@wing328
Copy link
Member Author

wing328 commented Oct 1, 2019

Merging it as it's just code formatting change.

@wing328 wing328 merged commit 31827f5 into master Oct 1, 2019
@wing328 wing328 added this to the 4.1.3 milestone Oct 1, 2019
@wing328 wing328 deleted the swift-enhance branch October 1, 2019 13:59
@wing328 wing328 changed the title [Swift4] update swift4 samples with swiftllint, update test scripts [Swift4] update swift4 samples with swiftlint, update test scripts Oct 1, 2019
Jesse0Michael pushed a commit to Jesse0Michael/openapi-generator that referenced this pull request Oct 3, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant