Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Java] fix jackson-databind-nullable version variable due to Gradle Incompatibility #4092

Merged
merged 2 commits into from
Oct 13, 2019
Merged

[Java] fix jackson-databind-nullable version variable due to Gradle Incompatibility #4092

merged 2 commits into from
Oct 13, 2019

Conversation

jburgess
Copy link
Contributor

@jburgess jburgess commented Oct 7, 2019 •
edited
Loading

Description of the PR

Removed the dashes from gradle version variables (jackson-databind-nullable-version) and replaced with underscores (jackson_databind_nullable_version)

See #3952

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

@wing328
Copy link
Member

wing328 commented Oct 9, 2019

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@jburgess
Copy link
Contributor Author

jburgess commented Oct 9, 2019

@wing328 thanks for taking the time to reach out on this. I believe I have made the correction.

wing328
wing328 approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 added this to the 4.2.0 milestone Oct 13, 2019
@wing328 wing328 merged commit dee6de7 into OpenAPITools:master Oct 13, 2019
@wing328 wing328 changed the title [Java][Fix #3952] jackson-databind-nullable version variable Gradle Incompatibility #3952 [Java]jackson-databind-nullable version variable Gradle Incompatibility #3952 Oct 13, 2019
@wing328 wing328 changed the title [Java]jackson-databind-nullable version variable Gradle Incompatibility #3952 [Java] fix jackson-databind-nullable version variable due to Gradle Incompatibility Oct 13, 2019
jimschubert added a commit that referenced this pull request Oct 14, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
9cdce66 
* master: (78 commits)
  Replaced dashes with underscores in build.gradle files. (#4092)
  [cxf-cdi] use @FormParam for form parameters when it is not Multipart (#4125)
  Corrections to script names (#4135)
  [python] Add missing keywords python (#4134)
  Update PULL_REQUEST_TEMPLATE.md (#4080)
  revert the fix to broken links
  Rename property name from propertyRawName to propertyBaseName (#4124)
  [Go] Fix go.mod and go.sum for 1.13 (#4084)
  [kotlin] add option for non public api (#4089)
  Added new discriminator RawName property to preserve declared discriminator for @JsonTypeInfo annotations (#3320)
  Fix links to other files (#4120)
  [JAVA][JAXRS] Fix parameters validation (#3862)
  Make Resttemplate thread safe by using the withHttpInfo pattern used by many other generated clients (#4049)
  Disabling linting for typescript-fetch (#4110)
  [Kotlin][Client] fix missing curly bracket when the model contains enum property (#4118)
  Fix NPE in Elm path parameter (#4116)
  test aiohttp first (#4117)
  add back ruby client folders
  update petstore samples
  [CLI] Initial implementation for batch generation (#3789)
  ...
@jmini
Copy link
Member

jmini commented Oct 14, 2019 •
edited
Loading

Thank you a lot for this PR.

Maybe I missed something, but this PR does not fix the problem at the root: in the mustache templates.

It would be great to have the output of the generator (files in samples/) aligned with the template (mustache file)
@GuruMeditator: can you also update:
https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/Java/build.gradle.mustache#L141

@wing328
Copy link
Member

wing328 commented Oct 14, 2019

@jmini good catch. I missed it.

@GuruMeditator please update the templates with another PR when you've time.

@jburgess jburgess mentioned this pull request Oct 14, 2019
Merged
@jburgess
Copy link
Contributor Author

Thanks @jmini. Not sure how I missed not including this in the PR. @wing328 updated in #4148

@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@jburgess thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
Client: Java Issue: Bug
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jburgess @wing328 @jmini