Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[swift4] Add swift package manager and update dependencies #4141

Merged

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Oct 13, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03)

Description of the PR

This PR add's support for Swift Package Manager, update dependencies and fixes #4057

@auto-labeler
Copy link

auto-labeler bot commented Oct 13, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@4brunu 4brunu changed the title [swift4] Add swift package manager [swift4] Add swift package manager and update dependencies Oct 13, 2019
@4brunu
Copy link
Contributor Author

4brunu commented Oct 15, 2019

cc: @wing328 can you please take a look at this? CI is failing but I think it's not related to this PR.

@4brunu
Copy link
Contributor Author

4brunu commented Oct 17, 2019

After merging master to this branch, it's now passing all the tests.
Can someone please look a this?
Thanks 🙂

@wing328
Copy link
Member

wing328 commented Oct 17, 2019

Let me run the test locally tomorrow. There were issues before due to XCode upgrade in my side.

@4brunu
Copy link
Contributor Author

4brunu commented Oct 17, 2019

Thanks 🙂

@wing328
Copy link
Member

wing328 commented Oct 18, 2019

Tests passed locally:

All tests
Test Suite SwaggerClientTests.xctest started
DateFormatTests
    ✓ testCodableAlwaysResultsInUTCEncodedDate (0.276 seconds)
    ✓ testEncodeToJSONAlwaysResultsInUTCEncodedDate (0.001 seconds)
PetAPITests
    ✓ test1CreatePet (1.254 seconds)
    ✓ test2GetPet (0.444 seconds)
    ✓ test3DeletePet (0.331 seconds)
StoreAPITests
    ✓ test1PlaceOrder (0.449 seconds)
    ✓ test2GetOrder (0.414 seconds)
    ✓ test3DeleteOrder (0.330 seconds)
    ✓ testDownloadProgress (0.403 seconds)
UserAPITests
    ✓ testLogin (0.451 seconds)
    ✓ testLogout (0.332 seconds)
    ✓ testPathParamsAreEscaped (0.000 seconds)


Executed 12 tests, with 0 failures (0 unexpected) in 4.686 (4.691) seconds

@wing328 wing328 merged commit c2ad14e into OpenAPITools:master Oct 18, 2019
@wing328 wing328 added this to the 4.2.0 milestone Oct 18, 2019
@4brunu 4brunu deleted the feature/swift-swift-package-manager branch November 25, 2019 10:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [Swift] Swift Package Manager integration
2 participants