Fixes Kotlin client property names that include a dollar sign #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
Thanks. I'll fix that up.
Andrew
------------
…On Wed, 23 Oct 2019 at 14:58, William Cheng ***@***.***> wrote:
Thanks for the PR but your commit (as shown in the Commits tab) is not
linked to your Github account, which means this PR won't count as your
contribution in
https://github.com/OpenAPITools/openapi-generator/graphs/contributors.
Let me know if you need help fixing it.
Ref:
https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4229?email_source=notifications&email_token=AAFHHBVLGFOS33PDPPE7OYLQP7DX5A5CNFSM4JDZVCL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB763YY#issuecomment-545254883>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFHHBQJEL2HLCSEQEBJQ2LQP7DX5ANCNFSM4JDZVCLQ>
.
|
Property names that include a dollar sign are being interpreted by Kotlin as a string template. This fix escapes such instances. OpenAPITools#4228
andrewemery
force-pushed
the
kotlin-client-unescaped-string-template
branch
from
02a1c41 to
5b2f5f3
Compare
CircleCI has nothing to do with this PR and has been addressed by CircleCI without anything being done in our side. |
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property names that include a dollar sign are being interpreted
by Kotlin as a string template. This fix escapes such instances.
#4228