Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mark Slim3 server generator as deprecated #4256

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

ybelenko
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Abandon Slim3 generator in favor of Slim4. #3658
It doesn't make sense to enhance/support generator based on outdated framework.

cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon

@wing328
Copy link
Member

wing328 commented Oct 25, 2019

Thanks for the PR.

Usually, we rename the generator with the suffix -deprecated as well, e.g. swift3-deprecated

@wing328 wing328 merged commit 5a7b471 into OpenAPITools:master Oct 26, 2019
@ybelenko ybelenko deleted the slim3_deprecated branch October 26, 2019 07:54
@wing328 wing328 added this to the 4.2.0 milestone Oct 30, 2019
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@ybelenko thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

@wing328
Copy link
Member

wing328 commented Oct 31, 2019

Yup, just updated my reply.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants