Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bash] Minor improvements #4274

Merged
merged 5 commits into from
Oct 26, 2019
Merged

[Bash] Minor improvements #4274

merged 5 commits into from
Oct 26, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 25, 2019

  • re-enable test cases in Travis
  • fix minor test issues
  • better handling of method naming
  • better handling of reserved words

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 changed the title [Bash] Minor improvement [Bash] Minor improvements Oct 25, 2019
@wing328 wing328 merged commit d5b09cf into master Oct 26, 2019
@wing328 wing328 deleted the bash_improve branch October 26, 2019 03:30
@wing328 wing328 added this to the 4.2.0 milestone Oct 30, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant