Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[r][license]: Fixing license and contact information #4317

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

saigiridhar21
Copy link
Contributor

@saigiridhar21 saigiridhar21 commented Oct 30, 2019

  • Using the license name specified on open api schema or else defaulting to Unlicense
  • Using the contact information specified on open api schema or else defaulting to open api generator community.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@Ramanth (2019/07)

@auto-labeler
Copy link

auto-labeler bot commented Oct 30, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@Ramanth
Copy link
Contributor

Ramanth commented Oct 30, 2019

Looks Good.

@wing328 wing328 added this to the 4.2.0 milestone Oct 30, 2019
@wing328 wing328 merged commit 2188e0f into OpenAPITools:master Oct 30, 2019
@saigiridhar21 saigiridhar21 deleted the fix/r/license branch October 30, 2019 09:11
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@saigiridhar21 thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants