[Golang][client] fix file suffix for _test.go #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. thanks |
|
All tests passed, but not at the same time yet. Occasionally, Circle CI cannot retrieve Java dependencies, Shippable runs into a race condition and Travis CI times out. Here are example messages for reference. Shippable - Build #1192.1 Travis CI - Build #1135 |
grokify
changed the title
|
Shippable CI error is not related to the change so merging this into master. Thanks for the enhancement. |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jul 7, 2018
* master: (116 commits) 3.1.0 release (OpenAPITools#486) Fix broken link to openapi generator plugin README (OpenAPITools#484) show warning message for nodejs server only (OpenAPITools#481) Add grokify to Go technical committee (OpenAPITools#479) [Slim] Improve codebase decouple (OpenAPITools#438) Ensure typescript samples are up to date (OpenAPITools#444) Update README.md [Golang][client] delete sample output dir before rebuild (OpenAPITools#477) update petstore samples (OpenAPITools#478) Revert "Improve Docker Tags (OpenAPITools#390)" update go client test dependencies (OpenAPITools#468) [Golang][client] fix for schema definition name `file` (OpenAPITools#433) Fix '.travis' file (syntax) make LICENSE GitHub display compatible (OpenAPITools#467) Improve Docker Tags (OpenAPITools#390) [Golang][client] fix file suffix for _test.go (OpenAPITools#449) Remove copy section (OpenAPITools#463) Add link to presentation (OpenAPITools#465) Use postProcessOperationsWithModels(Map, List) (OpenAPITools#431) [C] Adding petstore sample written in C (OpenAPITools#306) ...
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* add file suffix fix for _test.go * Trigger CI due to previous Shippable race condition * Trigger CI due to previous Shippable race condition * Trigger CI due to previous Travis CI stall * Trigger CI due to previous Travis CI stall * Trigger CI due to previous Shippable race condition * add Go client test testFilenames
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.@antihax
@bvwells
Description of the PR
Fixes #448
Adds an extra
_suffix to string returned bytoModelFilenameandtoApiFilenameif the suffix is_testresulting in a model or API file that ends in_test.gowhich is ignored by the Go compiler.samples/client/petstore/go/go-petstorewas rebuilt from scratch bybin/go-petstore.sh, aside fromsamples/client/petstore/go/go-petstore/api/swagger.yamlwhich is useful. May be worthwhile to have that auto-added along withopenapi.yaml.