Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FIX][Haskell-servant] missing indent on the new feature pull request. #4490

Merged
merged 4 commits into from
Nov 20, 2019
Merged

[FIX][Haskell-servant] missing indent on the new feature pull request. #4490

merged 4 commits into from
Nov 20, 2019

Conversation

Fjolnir-Dvorak
Copy link
Contributor

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

I messed up the Pull-Request #4056
Here is the fix containing three indentations.
@jonschoning could you please apply this fix?

@Fjolnir-Dvorak Fjolnir-Dvorak changed the title [FIX][Haskell-servant] missing indent on the new feature pull request. [FIX][Haskell-servant][WIP] missing indent on the new feature pull request. Nov 14, 2019
@Fjolnir-Dvorak Fjolnir-Dvorak changed the title [FIX][Haskell-servant][WIP] missing indent on the new feature pull request. [FIX][Haskell-servant] missing indent on the new feature pull request. Nov 14, 2019
@Fjolnir-Dvorak Fjolnir-Dvorak changed the title [FIX][Haskell-servant] missing indent on the new feature pull request. [FIX][Haskell-servant][WIP] missing indent on the new feature pull request. Nov 14, 2019
@Fjolnir-Dvorak Fjolnir-Dvorak changed the title [FIX][Haskell-servant][WIP] missing indent on the new feature pull request. [FIX][Haskell-servant] missing indent on the new feature pull request. Nov 14, 2019
@wing328 wing328 added this to the 4.2.2 milestone Nov 17, 2019
wing328
wing328 approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328
Copy link
Member

wing328 commented Nov 20, 2019

Drone.io failure has been addressed in the master.

@wing328 wing328 merged commit 23479b3 into OpenAPITools:master Nov 20, 2019
@Fjolnir-Dvorak Fjolnir-Dvorak deleted the bug/haskell/missingIndent branch November 20, 2019 11:12
@wing328
Copy link
Member

wing328 commented Dec 2, 2019

@Fjolnir-Dvorak thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
Client: Haskell Enhancement: Code format
Projects
None yet
Milestone
4.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Fjolnir-Dvorak @wing328