[JAVA] Update Gradle in generated Java projects from 2.14.1 to 6.0.1 #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymurray
changed the title
tobymurray
changed the title
If the user customize build.gradle template, it should be within their expectation the upgrade may not work. |
tobymurray
force-pushed
the
master
branch
2 times, most recently
from
004ee5e to
32a9c0c
Compare
|
I added 32a9c0c to reconcile the only case where a java project overrides the default Gradle wrapper, but I don't understand this bitrise CI failure. I don't think it's related to the work in this PR, or if it is I'm not clear how. |
When Java 11 native client library was introduced it was introduced with an overridden version of the Gradle wrapper (5.5 instead of 2.14.1). From looking at that PR, there doesn't appear to be any specific reason for the versions to differ. This removes the only override of the Gradle wrapper so all the Java projects are up to date and shares the same version.
|
Tested locally and the result is good. Thanks for the contribution. |
|
@tobymurray thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4535
Updated the Gradle version used in the generated Java client projects, as well as the samples. For my own use case (using OkHttp), the generated Java jar works without any changes, but I have no customizations in my
build.gradlethat may cause issues.So far as I can tell, Gradle is backwards compatible in the capacity it's used within these Java projects. With that said, this does not update the Gradle build script files to what would be more idiomatic of current Gradle, as I'm hoping the smaller the change the less contentious it is. A logical follow up of this would be to update e.g.
build.gradle.mustacheto reflect some of changes Gradle has made in the last few years.@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.