Support for KumuluzEE microprofile runtime #5944
Conversation
…with Kumuluzee framework.
… files from generator and library.
functional KumuluzEE REST client can now be generated.
|
Looks like you failed to do a rebase properly resulting in some commits not authored by you in the PR I would suggest you file a new PR by cherry-picking the commits and then resolve the merge conflicts if any. |
|
There are some commits authored by me, I also helped with the development. Is this a problem? |
|
@jmezna ah sorry I misread. Please resolve the merge conflicts and I'll merge (if local test results are good) |
| * {{{description}}} | ||
| **/ | ||
| {{/description}} | ||
| public class {{classname}} {{#parent}}extends {{{parent}}}{{/parent}}{{#serializableModel}} implements Serializable{{/serializableModel}} { |
There was a problem hiding this comment.
please add the option {{>additionalModelTypeAnnotations}} on the top of the public class {{ classname }} for users/developers to add custom annotations
…being another library option, removed now redundant library files.
|
@chuckle-dog There are some bugs in Microprofile rest client reported here #6028 which are being fixed now. I can see KumuluzEE microprofile rest client is reusing the code form Microprofile rest client which will have the same issues reported in #6028 |
|
@Ravisankar-Challa Is that going to be an issue? The additional property I added for framework selection only replaces the pom and adds two minor files in the case of KumuluzEE and does not affect the actual code that is generated. I also assumed the rest was functioning as specified, so any fixes to the generator to make it so should not affect the kumuluz framework option. |
|
@chuckle-dog Sorry you are right. I was looking a previous commit message. I don't see any issues in the latest commit. |
|
@chuckle-dog Please resolve the merge conflicts when you've time. |
|
@chuckle-dog can you please PM me via Slack when you've time? |
| this.setMicroprofileFramework(additionalProperties.get(MICROPROFILE_FRAMEWORK).toString()); | ||
|
|
||
| if (!MICROPROFILE_KUMULUZEE.equals(microprofileFramework)) { | ||
| throw new RuntimeException("Ivalid microprofileFramework '{}'. Must be 'kumuluzee' or none."); |
There was a problem hiding this comment.
I'll fix the typo (Ivalid => Invalid) and string interpolation '{}' in another PR.
| @@ -91,7 +96,9 @@ | |||
| // (mustache does not allow for boolean operators so we need this extra field) | |||
| protected boolean doNotUseRx = true; | |||
| protected boolean usePlayWS = false; | |||
| protected String playVersion = PLAY_26; | |||
| protected String playVersion = PLAY_25; | |||
There was a problem hiding this comment.
I'll change it back to PLAY_26 as the default play version in another PR.
|
Filed a follow-up PR: #7253 |
* master: (720 commits) [docs] Update README badges (#7276) Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259) [Dart] Get all enum values in a list (#7166) Update .gitattributes [ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false Update check-supported-versions.yaml [ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273) [core][bug] FILES is now path relative with no prefixes (#7271) Update check-supported-versions.yaml Update check-supported-versions.yaml (#7268) [Java][jersey2] Add jersey injection dependencies (#7240) [C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255) Date format dart (#6389) minor enhancement to java client generator (#7253) typescript: Fix Union Types Import Issue (#6789) Modifying the es5 and es6 templates for javascript to handle default values (#6649) [python-exp] simplify examples (#7157) Support for KumuluzEE microprofile runtime (#5944) [C#][netcore] minor improvements and bug fixes (#7244) Deprecate Flash (ActionScript) client generator (#7231) ...
* master: (219 commits) [java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052) [docs] Update README badges (OpenAPITools#7276) Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259) [Dart] Get all enum values in a list (OpenAPITools#7166) Update .gitattributes [ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false Update check-supported-versions.yaml [ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273) [core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271) Update check-supported-versions.yaml Update check-supported-versions.yaml (OpenAPITools#7268) [Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240) [C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255) Date format dart (OpenAPITools#6389) minor enhancement to java client generator (OpenAPITools#7253) typescript: Fix Union Types Import Issue (OpenAPITools#6789) Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649) [python-exp] simplify examples (OpenAPITools#7157) Support for KumuluzEE microprofile runtime (OpenAPITools#5944) [C#][netcore] minor improvements and bug fixes (OpenAPITools#7244) ...
Implemented support for KumuluzEE, #5939
Changes are limited to the addition of KumuluzEE templates and a new library option for the java and jaxrs-spec generators, as well as a single edit in the DefaultGenerator to add some required information regarding API class file names to the mustache bundle. These additions should not interfere with existing generator features.
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)