Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[codegen][python-experimental] Add configuration knob to disable JSON schema validation #6227

Merged

Conversation

sebastien-rosset
Copy link
Contributor

@sebastien-rosset sebastien-rosset commented May 8, 2020

  1. The 'multipleOf' keyword was not supported for INTEGER values, for any code generator
  2. The 'multipleOf' keyword was not supported for python-experimental
  3. Add Boolean value indicating whether to disable the JSON
    schema structural validation rules specified in the OpenAPI document.
    This includes multipleOf, maximum, exclusiveMaximum, minimum, exclusiveMinimum,
    maxLength, minLength, pattern...
    By default, the validation is performed for data generated locally by the client
    and data received from the server, independent of any validation performed by
    the server side.
    If the input data does not satisfy the JSON schema validation rules specified
    in the OpenAPI document, an exception is raised.
    If disable_validation is set to true, structural validation is disabled. This
    can be useful to troubleshoot data validation problem, such as when the OpenAPI
    document validation rules do not match the actual API data received by the server.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@sebastien-rosset
Copy link
Contributor Author

@spacether , @wing328

@sebastien-rosset sebastien-rosset changed the title [python-experimental] Add configuration knob to disable validation [python-experimental] Add configuration knob to disable JSON schema validation May 9, 2020
@sebastien-rosset sebastien-rosset marked this pull request as ready for review May 9, 2020 01:34
@sebastien-rosset sebastien-rosset changed the title [python-experimental] Add configuration knob to disable JSON schema validation [codegen][python-experimental] Add configuration knob to disable JSON schema validation May 12, 2020
…. add unit tests for JSON schema validation. Fix for python 2
@sebastien-rosset
Copy link
Contributor Author

@wing328

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the PR.

@spacether spacether added this to the 5.0.0 milestone May 17, 2020
@spacether spacether merged commit b4954b0 into OpenAPITools:master May 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants