-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[codegen][python-experimental] Add configuration knob to disable JSON schema validation #6227
Merged
spacether
merged 14 commits into
OpenAPITools:master
from
CiscoM31:python-add-knob-to-disable-validation
May 17, 2020
Merged
[codegen][python-experimental] Add configuration knob to disable JSON schema validation #6227
spacether
merged 14 commits into
OpenAPITools:master
from
CiscoM31:python-add-knob-to-disable-validation
May 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-rosset
changed the title
[python-experimental] Add configuration knob to disable validation
[python-experimental] Add configuration knob to disable JSON schema validation
May 9, 2020
spacether
reviewed
May 11, 2020
…ython-add-knob-to-disable-validation
…ython-add-knob-to-disable-validation
…. add unit tests for JSON schema validation
…. add unit tests for JSON schema validation
…. add unit tests for JSON schema validation
…ython-add-knob-to-disable-validation
sebastien-rosset
changed the title
[python-experimental] Add configuration knob to disable JSON schema validation
[codegen][python-experimental] Add configuration knob to disable JSON schema validation
May 12, 2020
…. add unit tests for JSON schema validation. Fix for python 2
spacether
reviewed
May 12, 2020
modules/openapi-generator/src/main/resources/python/configuration.mustache
Outdated
Show resolved
Hide resolved
spacether
reviewed
May 12, 2020
modules/openapi-generator/src/main/resources/python/configuration.mustache
Outdated
Show resolved
Hide resolved
spacether
approved these changes
May 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for the PR.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema structural validation rules specified in the OpenAPI document.
This includes multipleOf, maximum, exclusiveMaximum, minimum, exclusiveMinimum,
maxLength, minLength, pattern...
By default, the validation is performed for data generated locally by the client
and data received from the server, independent of any validation performed by
the server side.
If the input data does not satisfy the JSON schema validation rules specified
in the OpenAPI document, an exception is raised.
If disable_validation is set to true, structural validation is disabled. This
can be useful to troubleshoot data validation problem, such as when the OpenAPI
document validation rules do not match the actual API data received by the server.
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.