Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[php-slim4] Set required PHP version to 7.2 #6530

Merged
merged 11 commits into from
Jun 14, 2020

Conversation

ybelenko
Copy link
Contributor

@ybelenko ybelenko commented Jun 3, 2020

Update Slim4 package and rest dependencies to meet PHP 7.2 version.
I've tested build locally with PHP 7.2 and 7.3, there are warnings from PHPUnit but no critical errors or test fails.
Related issue #6522

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon

@ybelenko
Copy link
Contributor Author

ybelenko commented Jun 3, 2020

Travis CI fails because configured to old PHP 7.1 environment:

- phpenv global 7.1

@ybelenko ybelenko marked this pull request as draft June 7, 2020 12:02
@ybelenko ybelenko added this to the 5.0.0 milestone Jun 7, 2020
@ybelenko ybelenko force-pushed the 6522_slim4_server branch from 52c36f5 to e5b77d6 Compare June 14, 2020 10:05
@ybelenko ybelenko marked this pull request as ready for review June 14, 2020 10:07
@wing328 wing328 merged commit e282a05 into OpenAPITools:master Jun 14, 2020
@ybelenko ybelenko deleted the 6522_slim4_server branch June 14, 2020 14:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants