Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove localVariablePrefix #6588

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Remove localVariablePrefix #6588

merged 1 commit into from
Jun 10, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jun 8, 2020

Remove localVariablePrefix in Java files and templates as the local variable has been prefixed correctly to avoid naming collision with parameter names.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@wing328 wing328 added this to the 5.0.0 milestone Jun 10, 2020
@wing328 wing328 merged commit 104a2a3 into master Jun 10, 2020
@wing328 wing328 deleted the remove-localVariablePrefix branch June 10, 2020 09:22
@wing328 wing328 added Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. and removed Decommission labels Feb 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant