Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Go] fix unmarshal for models with parents #6946

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 15, 2020

  • Bugfix for models with parents (embedded struct) and additionalProperties: true to properly unmarshal.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

@wing328 wing328 added this to the 5.0.0 milestone Jul 15, 2020
@wing328 wing328 merged commit a348f5a into master Jul 16, 2020
@wing328 wing328 deleted the go-fix-additoinal branch July 23, 2020 02:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant