Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Play Framework] Update minor version + scala version + swagger-ui version #7200

Merged
merged 2 commits into from
Aug 15, 2020

Conversation

JFCote
Copy link
Member

@JFCote JFCote commented Aug 13, 2020

Update 3 versions in the generator + small fix in the url to the openapi.json in the swagger-ui built-in api page.
All the samples has been regenerated without problems.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@JFCote JFCote marked this pull request as draft August 13, 2020 14:02
@JFCote
Copy link
Member Author

JFCote commented Aug 13, 2020

WIP. Still has some errors in the /api. All related to filters and security, all new stuff in play 2.6.X

@JFCote JFCote marked this pull request as ready for review August 13, 2020 14:37
@JFCote
Copy link
Member Author

JFCote commented Aug 13, 2020

After validation, the error I was receiving were totally normal and expected. Ready for review and merge if everything is ok :)
About the circleci build, I don't know what is wrong since I can't see there error. Let me know if I can help.

@wing328 wing328 merged commit 14c14bf into master Aug 15, 2020
@wing328 wing328 deleted the update-play-framework-version branch August 15, 2020 09:25
@wing328 wing328 added this to the 5.0.0 milestone Aug 15, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants