Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[JavaScript] Update vulnerable dependencies #784

Merged
merged 8 commits into from
Aug 10, 2018

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Aug 10, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

visionmedia/superagent 3.5.2 is vulnerable to ZIP bomb attacks.
refs: NVD - CVE-2017-16129

It has been fixed in v3.7.0.

  • Limit maximum response size. Prevents zip bombs (Kornel)

@ackintosh
Copy link
Contributor Author

https://travis-ci.org/OpenAPITools/openapi-generator/builds/414479092?utm_source=github_status&utm_medium=notification

/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/javascript/src/api/AnotherFakeApi.js:65
this.123testSpecialTags = function(client, callback) {
^^^^
SyntaxError: Invalid or unexpected token

oh.. 👀

@wing328
Copy link
Member

wing328 commented Aug 10, 2018

Let me show you the fix (via gitter)

@wing328
Copy link
Member

wing328 commented Aug 10, 2018

and thanks for taking care of the security fix.

bin/javascript-petstore.sh
bin/javascript-es6-petstore.sh
bin/javascript-promise-petstore.sh
bin/javascript-promise-es6-petstore.sh
@ackintosh ackintosh force-pushed the security-vulnerabilities branch from b79c020 to 2ad623c Compare August 10, 2018 12:39
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wing328
Copy link
Member

wing328 commented Aug 10, 2018

cc @CodeNinjai @frol @cliffano

@wing328 wing328 merged commit 21777f2 into OpenAPITools:master Aug 10, 2018
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Aug 14, 2018
* master: (32 commits)
  Fixed date formatting in typescript node client (OpenAPITools#786)
  better explain usage (OpenAPITools#794)
  Fix float/double default value in C# generator (OpenAPITools#791)
  Enhancements to documentation generators (samples, default values, etc) (OpenAPITools#790)
  Remove duplicate variable declaration (OpenAPITools#792)
  Issue 758 root resource (OpenAPITools#771)
  Do not declare destructor as default when destructor is explicitly declared. (OpenAPITools#732)
  Fix C# client enum issue (OpenAPITools#774)
  [JavaScript] Update vulnerable dependencies (OpenAPITools#784)
  [Ruby] Fix method split (OpenAPITools#780)
  [Java][jaxrs-jersey] add sample with jaxrs-jersey + openapi v3 (OpenAPITools#778)
  update groupId in pom (OpenAPITools#779)
  [cpp-restsdk] Support multi-line descriptions (OpenAPITools#753)
  [Core] Resolve Inline Models (OpenAPITools#736)
  [gradle] Support nullable system property values (OpenAPITools#764)
  Correct URL for openapi-generator.cli.sh in README.md (OpenAPITools#770)
  Fixed the generation of model properties whose data type is a composed (allOf) schema (OpenAPITools#704)
  [JAX-RS][Spec] Add samples to CircleCI (OpenAPITools#759)
  minor update to python generator usage (OpenAPITools#762)
  [C++][Restbed/Pistache] Added fix for byte array (OpenAPITools#752)
  ...
@ackintosh ackintosh deleted the security-vulnerabilities branch August 15, 2018 02:11
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Update vulnerable dependencies

* Update samples: javascript-es6

* Update samples: javascript-promise

* Update samples: javascript-promise-es6

* Update samples: javascript

* Update samples: petstore-security-test/javascript

* Rename operationId if it starts with a number

* Update samples

bin/javascript-petstore.sh
bin/javascript-es6-petstore.sh
bin/javascript-promise-petstore.sh
bin/javascript-promise-es6-petstore.sh
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants