-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Removes secondaryParam and hasMore #7882
Removes secondaryParam and hasMore #7882
Conversation
modules/openapi-generator/src/main/resources/Groovy/api.mustache
Outdated
Show resolved
Hide resolved
26a0932
to
b6e34ae
Compare
b6e34ae
to
fc81c68
Compare
Looks like somes tests need to be updated accordingly as well:
|
cc @OpenAPITools/generator-core-team as well |
|
FYI. Some comments still are still referencing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR removes the properties
because these parameters are booleans that are used to control rendering in mustache templates
We can remove these because mustache already has #-first and #-last and ^-first and ^-last tags
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master