Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix version for "spring-boot-maven-plugin" #85

Merged
merged 2 commits into from
May 17, 2018
Merged

Fix version for "spring-boot-maven-plugin" #85

merged 2 commits into from
May 17, 2018

Conversation

jmini
Copy link
Member

@jmini jmini commented May 17, 2018

This should fix the warnings we see at the beginning of the maven build:

[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.openapitools:openapi-generator-online:jar:3.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.springframework.boot:spring-boot-maven-plugin is missing. @ line 33, column 21
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]

@cbornet can you have a look?

@cbornet
Copy link
Member

cbornet commented May 17, 2018

I would call the property spring-boot-version since it’s not applied only to the plugin.
Otherwise LGTM

@jmini
Copy link
Member Author

jmini commented May 17, 2018

Yes thank you... I used it first for the maven plugin, then I have seen it should be used for the BOM.

@jmini jmini requested a review from cbornet May 17, 2018 08:42
@jmini
Copy link
Member Author

jmini commented May 17, 2018

@cbornet: can you approve the change?

@jmini jmini merged commit 3a1922b into OpenAPITools:master May 17, 2018
@jmini jmini deleted the fix_spring_version branch May 17, 2018 09:28
@wing328 wing328 added this to the 3.0.0 milestone May 17, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cbornet cbornet cbornet approved these changes

Assignees
No one assigned
Labels
Enhancement: CI/Test
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jmini @cbornet @wing328