Add more information to crawler output #49
Conversation
| Name: rf_computersystem.Name, | ||
| Manufacturer: rf_computersystem.Manufacturer, | ||
| SystemType: string(rf_computersystem.SystemType), |
There was a problem hiding this comment.
Any reason you are calling string() here? I notice the other right-hand values above and below don't have itand they are of type string.
There was a problem hiding this comment.
Not sure, since I didn't add that myself. I think it was added automatically by gofmt. I'll take a closer look at it.
There was a problem hiding this comment.
After looking at the gofish code, I think it's to cast from SystemType to a string, since SystemType is the actual type of rf_computersystem.SystemType.
|
Probably worth mentioning that with the creation of central schemas, I'm going to repurpose this PR to import and use them rather than the structs here in magellan. |
|
I merged this one. I think a new PR is in order for the schema changes |
This PR includes more usable information to be parsed by SMD to build component and component endpoints.