Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Capture release timer #858

Closed
NikkiLacrima opened this issue Aug 22, 2022 · 0 comments
Closed

Capture release timer #858

NikkiLacrima opened this issue Aug 22, 2022 · 0 comments

Comments

@NikkiLacrima
Copy link
Contributor

What version of OpenCollar are you using? 8.1

Two strange issues in capture.

  1. The 1 second timer tick is not restarted on a captured collar after a relog, or collar rewear.

This can be tested by following steps:

  • Capture wearer with autorelease active
  • Wearer relogs or simply rewears the collar (triggering a reset and settings restore)
  • Captor tp away, the autorelease timer is not started, and capture is still active

If the wearer opens and uses the capture menu, then the autorelease timer tick is restarted.
The cause is that llSetTimerEvent(1) is called from Commit(), but this does not happen when settings are restored on a captured collar, but it is called when accessing the menu

  1. If the wearer turns off capture while captured, disabling further recapture so not an unreasonable action, then the 10 minute release timer is started but the actual release on timeout fails and another 10 minute release period is started.
  • Capture wearer with autorelease active
  • Captor TP away
  • Wearer disables capture at any time before the autorelease

This is caused by the test for g-iEnabled on line 183, and a possible fix is the following:

—-- 183:     if(!g_iEnabled)return;
+++ 183:     if(!g_iEnabled && !g_iCaptured)return;
@SilkieSabra SilkieSabra moved this from New to In Progress in OpenCollar Issues Board Jul 26, 2023
Pingout added a commit that referenced this issue Jul 27, 2023
A revision to PR #969 
This update has most of the features of 969 without the bugs, plus an important detail:
1) Owner can now end a Capture Issue #903 
2) Owner and Captor are both notified of successful Capture and End of Capture
3) BLOCKED individuals can not Capture Issue #959
4) Wearer can end Capture when Risky is off
5) When Risky is active, the Captive's only escape is using Safeword
6) Fixes a bug in the timer when Captive relogs and Captor leaves the sim Issue #858
Pingout added a commit that referenced this issue Jul 27, 2023
Fixed the first half of the Issue #858
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenCollar Issues Board Aug 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants