Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Suggestion: unwelder check order of welded <-> addonslimit #907

Closed
Pyhrn opened this issue Dec 6, 2022 · 0 comments
Closed

Suggestion: unwelder check order of welded <-> addonslimit #907

Pyhrn opened this issue Dec 6, 2022 · 0 comments

Comments

@Pyhrn
Copy link

Pyhrn commented Dec 6, 2022

Currently when starting the unwelding-process the script checks first for the addonslimit flag, and only after that if the collar is even welded.
Imho it is rather pointless to send the wearer on an adventure to their owner for lifting addonslimit just to find out on return their collar hasn't been welded in first place.

Pingout added a commit that referenced this issue Dec 10, 2022
Slight change to the order of operations to first check if the collar is welded before checking if the Addon Limited is unchecked
Pingout added a commit that referenced this issue Dec 11, 2022
Fix for issue #907, order of Welded -> Addon Limited checking
Pingout added a commit that referenced this issue Dec 11, 2022
Fix for issue #907, order of Welded -> Addon Limited checking
Pingout added a commit that referenced this issue Dec 11, 2022
Fix for issue #907, order of Welded -> Addons Limited checking
Pingout added a commit that referenced this issue Dec 11, 2022
Fix for Issue #907, order of welded <-> addonslimit checking
SilkieSabra added a commit that referenced this issue Jul 27, 2023
Unwelder: Possible solution to Issue #907
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants