-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Sound normalization #1031
Sound normalization #1031
Conversation
Loudness normalization to -14LUFS
Uploaded new sounds files and updated readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this inworld and found the sounds much improved. Where previously you could barely hear many of the bell sounds, you can now hear all of them clearly, and even be able to adjust the volume down and still hear the sound. Thank you!
Oh and I moved the PR so that it now points at the 8.3 Features Branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change is just a change of the sound list, zero problems there.
@Trix7125 can you add an update line to the comments at the top to show your revision, in along the lines:
Trix (SL name in brackets if you want):
27 feb 2024: Updated bell sounds to normalise volume, and replaced g_listBellSounds with new values.
Also we don't really need the old values commented out, please delete those.
Nice work! Thanks very much.
Removed old list of sounds.
I removed the old list and added commend top of file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as edited. We still need to point all Pull Requests at the 8.3 Features Branch of the repository until such time as we are ready to Upgrade to the next Version.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trix7125
Thanks for the changes! All good now.
d5ec722
into
OpenCollarTeam:8.3_Features-branch
Fix the bell sounds that you can actually hear something.