Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sound normalization #1031

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

Trix7125
Copy link
Contributor

Fix the bell sounds that you can actually hear something.

Loudness normalization to -14LUFS
Uploaded new sounds files and updated readme.
@Pingout Pingout changed the base branch from master to 8.3_Features-branch February 16, 2024 14:35
Copy link
Collaborator

@Pingout Pingout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this inworld and found the sounds much improved. Where previously you could barely hear many of the bell sounds, you can now hear all of them clearly, and even be able to adjust the volume down and still hear the sound. Thank you!

@Pingout
Copy link
Collaborator

Pingout commented Feb 16, 2024

Oh and I moved the PR so that it now points at the 8.3 Features Branch

Copy link
Collaborator

@Medea-Destiny Medea-Destiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is just a change of the sound list, zero problems there.

@Trix7125 can you add an update line to the comments at the top to show your revision, in along the lines:

Trix (SL name in brackets if you want):
27 feb 2024: Updated bell sounds to normalise volume, and replaced g_listBellSounds with new values.

Also we don't really need the old values commented out, please delete those.

Nice work! Thanks very much.

Removed old list of sounds.
@Trix7125
Copy link
Contributor Author

Trix7125 commented Mar 1, 2024

I removed the old list and added commend top of file.

@Trix7125 Trix7125 requested a review from Medea-Destiny March 1, 2024 18:16
Copy link
Collaborator

@Pingout Pingout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as edited. We still need to point all Pull Requests at the 8.3 Features Branch of the repository until such time as we are ready to Upgrade to the next Version.
Thank you!

Copy link
Collaborator

@Medea-Destiny Medea-Destiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trix7125
Thanks for the changes! All good now.

@SilkieSabra SilkieSabra merged commit d5ec722 into OpenCollarTeam:8.3_Features-branch Mar 4, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants