Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change legacy permissions notification in oc_couples #1082

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Medea-Destiny
Copy link
Collaborator

Message " Inviting (couple partner) to a couples animation using legacy permissions." when not using autoacc might be confusing. Just remove "using legacy permissions".

Message " Inviting (couple partner) to a couples animation using legacy permissions." when not using autoacc might be confusing. Just remove "using legacy permissions".
@Medea-Destiny Medea-Destiny added 8.3 Ready to merge Discussion wanted Request for community feedback and removed Ready to merge labels Aug 20, 2024
@Medea-Destiny
Copy link
Collaborator Author

OK, let's have a quick discussion on this, as it does remove useful info. Better wording suggestions? Perhaps something along the lines "Inviting (partner) to couples animation and awaiting them to accept animate permission"?

@SilkieSabra
Copy link
Contributor

Honestly my feeling is that the behavior where the person with collar access accepts an animation permission request from the wearer is the existing configuration and does not need to have its text changed. "Inviting (partner) to a couples animation" already implies waiting for consent. That much is fine, and additional information about what would happen if you had x button checked instead, does not further anything.

@Pingout
Copy link
Collaborator

Pingout commented Aug 20, 2024

I feel less chatty is better.

@SilkieSabra
Copy link
Contributor

SilkieSabra commented Aug 26, 2024

Another thought on this one.. the couples line is in the domain of rp, mixing in tech speak is jarring.

@SilkieSabra
Copy link
Contributor

SilkieSabra commented Sep 3, 2024

My pr was intended to resolve the discussion since there was no response to three posts. Please explain why you feel this change to the message users see when they issue a couples invitation is a necessary change. I misread how you posted it in the first place. If there is nothing further to say, let's merge it.

@SilkieSabra SilkieSabra merged commit a1a9c97 into 8.3_Features-branch Sep 3, 2024
2 checks passed
@SilkieSabra SilkieSabra deleted the Medea-Destiny-8.3beta2fixes-3 branch September 3, 2024 15:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Discussion wanted Request for community feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants