Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix warnings in test helpers #202

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

joshvazquez-amzn
Copy link
Contributor

Fix unused variable warnings and sign conversion warning in test helpers.

#201

Fix unused variable warnings and sign conversion warning in test helpers.
@joshvazquez-amzn joshvazquez-amzn changed the title Fix warnings in test helpers Fix warnings in test helpers #201 Oct 13, 2022
@joshvazquez-amzn joshvazquez-amzn changed the title Fix warnings in test helpers #201 Fix warnings in test helpers Oct 13, 2022
@pavel-kirienko
Copy link
Member

Please fix the formatting as indicated by the broken check, otherwise it looks good. Thanks!

@pavel-kirienko pavel-kirienko enabled auto-merge (squash) October 13, 2022 20:04
auto-merge was automatically disabled October 13, 2022 20:08

Head branch was pushed to by a user without write access

@pavel-kirienko pavel-kirienko enabled auto-merge (squash) October 13, 2022 20:09
@joshvazquez-amzn
Copy link
Contributor Author

Whoops, I missed committing the change to that last line after running clang-format.

@pavel-kirienko pavel-kirienko linked an issue Oct 13, 2022 that may be closed by this pull request
@pavel-kirienko pavel-kirienko merged commit f85103b into OpenCyphal:master Oct 13, 2022
@joshvazquez-amzn joshvazquez-amzn deleted the patch-2 branch October 13, 2022 20:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tests enable -Werror but generate warnings
2 participants