Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add functions for parameter validity check and parameter transformation #308

Closed
FlorianK13 opened this issue Jul 25, 2022 · 1 comment · Fixed by #337
Closed

Add functions for parameter validity check and parameter transformation #308

FlorianK13 opened this issue Jul 25, 2022 · 1 comment · Fixed by #337
Assignees
@FlorianK13 @deniztepe
Labels
🚀 feature New feature or request

Comments

@FlorianK13
Copy link
Member

Create new set of functions or edit existing functions that can handle the parameter harmonisation adressed in #252:

  • validate_parameter_tables(method, data) checks if parameter values and chosen method ("API" or "bulk") work together
  • transform_parameter creates new parameters that are needed for the download depending on the user input (such as api_location_types if "location" in data and method="API")
@FlorianK13 FlorianK13 added the 🚀 feature New feature or request label Jul 25, 2022
chrwm added a commit that referenced this issue Jul 25, 2022
@chrwm
Relocate API credential information #308
20c917a
@chrwm chrwm mentioned this issue Jul 25, 2022
Merged
1 task
chrwm added a commit that referenced this issue Jul 25, 2022
@chrwm
Extend API credential information #308
5edbcfe
@deniztepe deniztepe mentioned this issue Aug 18, 2022
Closed
deniztepe added a commit that referenced this issue Aug 19, 2022
@deniztepe
Validate parameter data and differentiate between api and bulk data #308
ef936f2
deniztepe added a commit that referenced this issue Aug 19, 2022
@deniztepe
Rename technology to data #308
d2f3ac0 
The parameter 'technology' is replaced with 'data' wherever it means more than only technologies.
It requires a thorough scan of scripts for a consistent refactoring.
The documentation must be adapted as well.
deniztepe added a commit that referenced this issue Aug 22, 2022
@deniztepe
Validate that list parameters are not empty lists #308
f53db88 
[None], [] are not valid anymore
deniztepe added a commit that referenced this issue Aug 22, 2022
@deniztepe
Transform and harmonize data input #308
9fe4e88 
*api_data_types and api_location_types default now to all possible selections.
* transform function returns lists required from lower functions -> lower functions must handle only lists -> no parsing etc.
deniztepe added a commit that referenced this issue Aug 22, 2022
@deniztepe
Add test #308
2d188bb
@FlorianK13 FlorianK13 mentioned this issue Aug 22, 2022
Closed
5 tasks
deniztepe added a commit that referenced this issue Aug 22, 2022
@deniztepe
Remove redundant parsing of data parameter #308
99f4fda 
* Black applied
deniztepe added a commit that referenced this issue Aug 24, 2022
@deniztepe
Adapt documentation for data parameter #308
110ed24 
* Technology is renamed to data where necessary
* In docstring, a table for possible data values is added
deniztepe added a commit that referenced this issue Aug 24, 2022
@deniztepe
Edit Changelog #308
f1579bb
@deniztepe deniztepe linked a pull request Aug 24, 2022 that will close this issue
Feature 308 transform technology parameter #337
Merged
chrwm added a commit that referenced this issue Aug 26, 2022
@chrwm
Fix soap_API tqdm message #308
a1fd835
FlorianK13 added a commit that referenced this issue Aug 29, 2022
@FlorianK13
Merge pull request #337 from OpenEnergyPlatform/feature-308-transform…
9717527 
…-technology-parameter

Feature #308 transform technology parameter

Closes #308
@FlorianK13
Copy link
Member Author

Closed with #337

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@FlorianK13 FlorianK13

@deniztepe deniztepe

Labels
🚀 feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature 308 transform technology parameter OpenEnergyPlatform/open-MaStR
2 participants
@FlorianK13 @deniztepe