Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue template user_kudos.md #544

Closed
1 task
chrwm opened this issue Jun 7, 2024 · 4 comments · Fixed by #545
Closed
1 task

Fix issue template user_kudos.md #544

chrwm opened this issue Jun 7, 2024 · 4 comments · Fixed by #545
Assignees

Comments

@chrwm
Copy link
Member

chrwm commented Jun 7, 2024

Description of the issue

The workflow to populate USERS.cff doesn't like the double quotes in user_kudos.md
Without them special characters and spaces are processes as expected.

Ideas of solution

Remove double quotes in user_kudos.md

Context and Environment

  • Version used:
  • Operating system:
  • Environment setup and (python) version:

Workflow checklist

@chrwm chrwm self-assigned this Jun 7, 2024
@FlorianK13
Copy link
Member

Also the "Many thanks FlorianK13!" should be a "Many thanks @FlorianK13"

chrwm added a commit that referenced this issue Jun 7, 2024
@chrwm chrwm mentioned this issue Jun 7, 2024
5 tasks
@chrwm chrwm linked a pull request Jun 7, 2024 that will close this issue
5 tasks
@FlorianK13
Copy link
Member

@chrwm were the problems we saw in the last merge on production fixed by you? So can we merge the new PRs to develop?

@chrwm
Copy link
Member Author

chrwm commented Jul 1, 2024

Yes the fix is ready for review in #545

@FlorianK13
Copy link
Member

Ok, I reviewed. You can merge if it is ready.

@chrwm chrwm closed this as completed Jul 1, 2024
This was referenced Oct 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants