Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix 367 postgres missing column handling #370

Merged
merged 9 commits into from
Nov 15, 2022

Conversation

FlorianK13
Copy link
Member

No description provided.

The error message in postgres changed, so
the handling had to be adapted to retreive the missing
column.
Newly created column and table names are now
logged.
@FlorianK13 FlorianK13 requested a review from deniztepe November 11, 2022 09:31
@deniztepe
Copy link
Contributor

deniztepe commented Nov 11, 2022

I am testing it currently with a new download. It seems like the new columns could be arranged in orm.py . API and xml column names are slightly different. For instance:

Hoechstbemessungsleistung = Column(Float)
BiogasHoechstbemessungsleistung = Column(Float)

@deniztepe
Copy link
Contributor

deniztepe commented Nov 11, 2022

Does the failing test mean there are new columns again?

TypeError: 'eegAusschreibungZuschlag' is an invalid keyword argument for StorageEeg

@FlorianK13
Copy link
Member Author

FlorianK13 commented Nov 11, 2022

No, I deleted that column because it was not in the documentation. But it comes from the API download apparently, so we need to reintroduce it.

@chrwm
Copy link
Member

chrwm commented Nov 11, 2022

Does this mean there were new columns added to the XML? Or API? - in addtion to #351?
I don't understand the bug from the issue.

@deniztepe
Copy link
Contributor

New columns were added to XML, which were undergoing because of automatic column adding as error handling. This handling was not working with local postgres databases apparently.

@FlorianK13 FlorianK13 merged commit a729791 into develop Nov 15, 2022
@FlorianK13 FlorianK13 deleted the bugfix-367-postgres-missing-column-handling branch November 15, 2022 09:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants