Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bugfix 420 csv export engine #421

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Bugfix 420 csv export engine #421

merged 2 commits into from
Jan 30, 2023

Conversation

deniztepe
Copy link
Contributor

@deniztepe deniztepe commented Jan 30, 2023 •
edited
Loading

pd.read_sql is called with an explicit connection

Related to #405

@deniztepe deniztepe added the 🐛 bug Something isn't working label Jan 30, 2023
@deniztepe deniztepe requested review from chrwm and FlorianK13 January 30, 2023 09:42
@deniztepe deniztepe self-assigned this Jan 30, 2023
@deniztepe deniztepe changed the base branch from production to develop January 30, 2023 09:43
@deniztepe deniztepe linked an issue Jan 30, 2023 that may be closed by this pull request
CSV export fails due to engine settings #420
Closed
@FlorianK13
Copy link
Member

I get the following error when running the tests locally:

FAILED tests/xml_download/test_utils_write_to_database.py::test_add_table_to_database - KeyError: "['Energietraeger'] not in index"

This is probably not related to this PR, right?

@deniztepe
Copy link
Contributor Author

Doesn't sound relevant with this PR

chrwm
chrwm approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@chrwm chrwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks for implementing.

@deniztepe deniztepe merged commit 395778f into develop Jan 30, 2023
@deniztepe deniztepe deleted the bugfix-420-csv-export-engine branch January 30, 2023 10:37
@deniztepe deniztepe mentioned this pull request Jan 30, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chrwm chrwm chrwm approved these changes

@FlorianK13 FlorianK13 Awaiting requested review from FlorianK13

Assignees

@deniztepe deniztepe

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV export fails due to engine settings
3 participants
@deniztepe @FlorianK13 @chrwm