-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Create Mastr.translate method #461 #471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @Grazvy I have added a few comments, we can also discuss them further.
Github secrets are not communicated to external PRs, hence the API tests cannot run successfully. I propose we merge it anyway and see if the tests run when we want to merge to production? |
The tests for this branch are also failing locally, I will investigate why this is the case before we merge. |
Tests suceeded locally, hence I will merge it now |
Summary of the discussion
Describe the findings of the discussion in the issue or meeting.
Type of change (CHANGELOG.md)
Added
Updated
Removed
Workflow checklist
Automation
Closes #
PR-Assignee
Reviewer