Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create Mastr.translate method #461 #471

Merged
merged 16 commits into from
Nov 3, 2023

Conversation

Grazvy
Copy link
Contributor

@Grazvy Grazvy commented Oct 11, 2023

Summary of the discussion

Describe the findings of the discussion in the issue or meeting.

Type of change (CHANGELOG.md)

Added

  • New method in mastr.py to translate the columns of the connected database
  • Dictionary of translations in constants.py
  • Methods in helpers.py for translating and connecting to a translated database
  • Tests for new functionality

Updated

  • Mastr class parameters to allow connections to translated databases

Removed

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

Copy link
Member

@FlorianK13 FlorianK13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @Grazvy I have added a few comments, we can also discuss them further.

@FlorianK13 FlorianK13 changed the title Develop Create Mastr.translate method #461 Oct 18, 2023
@FlorianK13 FlorianK13 marked this pull request as ready for review November 2, 2023 07:34
@FlorianK13 FlorianK13 linked an issue Nov 2, 2023 that may be closed by this pull request
1 task
@FlorianK13
Copy link
Member

Github secrets are not communicated to external PRs, hence the API tests cannot run successfully. I propose we merge it anyway and see if the tests run when we want to merge to production?

@FlorianK13
Copy link
Member

The tests for this branch are also failing locally, I will investigate why this is the case before we merge.

@FlorianK13
Copy link
Member

Tests suceeded locally, hence I will merge it now

@FlorianK13 FlorianK13 merged commit 5553bc9 into OpenEnergyPlatform:develop Nov 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Mastr.translate method
2 participants