Sync local SM PDIreg with ESC PDIreg at Mbx start #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting mailbox service, write the value of ECAT RepeatRequest to PDI RepeatAck. Otherwise it is risk of a race condition when running CTT and the repeat ack would hold the value of previous repeat ack test. The race condition occurs on slow targets that doesn't handle the repeat request fast enough. The resulting mailbox read will come before the mailbox is emptied on the SM changed event. fixes
nakarlsson
force-pushed
the
fix/reset_esc_repeat_ack
branch
from
ea46b50 to
d04bed4
Compare
ArthurKetels
approved these changes
Mar 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting mailbox service, write the value of
ECAT RepeatRequest to PDI RepeatAck. Otherwise
it is risk of a race condition when running
CTT and the repeat ack would hold the value
of previous repeat ack test.
The race condition occurs on slow targets
that doesn't handle the repeat request
fast enough. The resulting mailbox read
will come before the mailbox is emptied
on the SM changed event.
fixes #169