Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Kobotoolbox improve pagination #990

Closed
wants to merge 3 commits into from

Conversation

PiusKariuki
Copy link
Collaborator

Summary

Add pagination parameters for getSubmissions function

Fixes #988

Details

  • Passed start and limit options to the http.get
  • Added a test for the above behaviour

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

@josephjclark
Copy link
Collaborator

Hi @PiusKariuki - did someone ask you to do this?

We're just in the process of testing a new Kobo adaptor. I should have been clearer in the issue but the work should be targeted at the epic/kobo branch, rather than main.

I think we need to defer this for the moment, sorry :( I'll reach out to you to find a better issue for you to be working on.

@PiusKariuki
Copy link
Collaborator Author

Hi @josephjclark . Nobody asked me to do this. It's alright. Sure, please reach out if you find anything suitable.
Thanks.

@josephjclark
Copy link
Collaborator

Thank you, I'm really sorry! I'm just trying to work something out now :)

@PiusKariuki
Copy link
Collaborator Author

Ah don't stress it. Atleast I got to learn how Kobo really works with this. One more adaptor I can be useful on. It's a win in my book.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

kobotoolbox: improve pagination
2 participants