added Binary Heap #3959
Merged
added Binary Heap #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavb
requested changes
Mar 1, 2019
| public: | ||
| BinaryHeap() | ||
| {} | ||
| void Insert(int element); |
There was a problem hiding this comment.
Please name variables with camelCase.
| void BinaryHeap::DeleteMin(){ | ||
|
|
||
| if (heap.size() == 0){ | ||
| std::cout << "Heap is Empty"<< std::endl; |
There was a problem hiding this comment.
Please raise an exception instead.
| int BinaryHeap::left(int parent){ | ||
| int l = 2 * parent + 1; | ||
|
|
||
| if (l < heap.size()) |
There was a problem hiding this comment.
You could use a single line ternary for this whole function.
|
|
||
| // Return Parent | ||
| int BinaryHeap::parent(int child){ | ||
| int p = (child - 1)/2; |
There was a problem hiding this comment.
Also here and in the previous 2 functions.
arnavb
approved these changes
Mar 2, 2019
|
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
Changes:
Binary Heapwith its C++ implementation.