Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed Network Preferences on Big Sur #209

Merged

Conversation

ErrorErrorError
Copy link
Collaborator

@ErrorErrorError ErrorErrorError commented Nov 21, 2020

Hey!

Just a minor fix with Network Preferences not looking like a preference panel for devices >= 11.0. This is how it looked like before:
Screen Shot 2020-11-20 at 7 11 31 PM

After with this fix:
Screen Shot 2020-11-20 at 7 12 10 PM

Edit: Also improved with the logging system for devices >= macOS 11.0. For itlwm, I added https://openintelwireless.github.io/itlwm/Troubleshooting.html#using-dmesg so the user can extract itlwm since Big Sur does not load logs from bootloader using the log command.

Ready for review!

… style on systems >= 11.0.

	- Improved visibility for table view while viewing wireless networks.
	- Improved tableview appearance to match big sur and it's SF Symbols.
	- Minor fix with width of tableview rows.
@ErrorErrorError ErrorErrorError added the enhancement New feature or request label Nov 21, 2020
…and use Unified Logging System to retrieve logs for HeliPort.

	- Added a link to log to tell users to get their logs by running dmesg if running Big Sur or higher.
	- Added OS version on the log
Copy link
Collaborator

@williambj1 williambj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

The Prefs Window looks perfect, the code for that part looks good as well.

We might need to inform the users about the issues during the log generation process, especially the one that asks users to add msgbuf and use dmesg. I think we could show an alert with Error occurred while generating bug report as the message and append the errors to informativeText.

Maybe checking the existence of msgbuf in boot-args and then generate proper logs would be a better approach?

HeliPort/Supporting files/BugReporter.swift Outdated Show resolved Hide resolved
HeliPort/Supporting files/BugReporter.swift Outdated Show resolved Hide resolved
HeliPort/Supporting files/BugReporter.swift Outdated Show resolved Hide resolved
HeliPort/Supporting files/BugReporter.swift Outdated Show resolved Hide resolved
HeliPort/Supporting files/BugReporter.swift Outdated Show resolved Hide resolved
@williambj1 williambj1 added this to the v1.0.2 milestone Nov 21, 2020
@ErrorErrorError
Copy link
Collaborator Author

We might need to inform the users about the issues during the log generation process, especially the one that asks users to add msgbuf and use dmesg. I think we could show an alert with Error occurred while generating bug report as the message and append the errors to informativeText.

Maybe checking the existence of msgbuf in boot-args and then generate proper logs would be a better approach?

Sounds like thats a better approach to me. We can also ask the user to input their credentials kind of how I have it so it can show the user's stored wifi password but instead for dmesg, but well that's just an idea for now.

@ErrorErrorError
Copy link
Collaborator Author

Feel free to add/improve on script execution. Couldn't manage to call dmesg without asking for permission to the user, and being able to change the text of the alert. The good thing it only asks for devices >= macOS 11.0

@williambj1 williambj1 merged commit 68a9cd5 into OpenIntelWireless:master Jan 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants