Support currencies in openleadr-wire (#54) #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This addresses #54.
In the issue it's left open whether to add currency support via a crate or by manually maintaining the list of current currencies listed here. The iso_currency crate seems popular (65k recent downloads) and maintained (last updated three months ago), and easy enough to integrate, so I opted to use it. I'd be happy to copy/paste the enum from that crate if you'd rather maintain it manually.
Also added a couple simple tests demonstrating serde for the currency field in
EventPayloadDesciptor
.