<springBootApplication/> issue fix #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n server.xml <springBootApplication/> node Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
requested changes
Nov 15, 2024
There was a problem hiding this comment.
I think the changes are good, but we need some negative tests added.
- More than one springBootApplication element specified to trigger the exception. Need to use invoker.properties for that.
- Specify the
appsfolder but do not provide the configuration for the springBootApplication and test that the config gets generated in the configDropins folder.
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
requested changes
Nov 18, 2024
...ingboot-3-deploy-multiple-springboot-application-nodes-fail-it/src/test/resources/server.xml
Outdated
Show resolved
Hide resolved
...s/springboot-3-appsdirectory-apps-it/src/test/java/application/InstallSpringBoot30AppIT.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/test/resources/checkErrorVersionlessFeature.bsh
Outdated
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
requested changes
Nov 20, 2024
liberty-maven-plugin/src/it/springboot-3-appsdirectory-apps-fail-it/pom.xml
Outdated
Show resolved
Hide resolved
...n/src/it/springboot-3-tests/springboot-3-appsdirectory-server-xml-springboot-node-it/pom.xml
Show resolved
Hide resolved
.../springboot-3-appsdirectory-server-xml-springboot-node-it/src/main/liberty/config/server.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
requested changes
Nov 20, 2024
liberty-maven-plugin/src/test/resources/checkErrorVersionlessFeature.bsh
Outdated
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
approved these changes
Nov 20, 2024
cherylking
requested changes
Nov 20, 2024
liberty-maven-plugin/src/test/resources/checkErrorVersionlessFeature.bsh
Outdated
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
approved these changes
Nov 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making change to create thin application with same name as provided in server.xml node